Feedback & unset max-height in BaseTable

evergreen-ci · Oct 9, 2023 · b4f0bba · b4f0bba
1 parent 1f6ea78
commit b4f0bba
Show file tree

Hide file tree

Showing 2 changed files with 12 additions and 4 deletions.
diff --git a/src/components/Table/BaseTable.tsx b/src/components/Table/BaseTable.tsx
@@ -1,3 +1,4 @@
+import { css } from "@leafygreen-ui/emotion";
 import {
   Cell,
   ExpandedContent,
@@ -43,7 +44,16 @@ export const BaseTable = <T extends LGRowData>({
       </TableHead>
       <TableBody>
         {table.getRowModel().rows.map((row) => (
-          <Row key={row.id} row={row} data-cy={dataCyRow}>
+          <Row
+            key={row.id}
+            row={row}
+            data-cy={dataCyRow}
+            className={css`
+              &[aria-hidden="false"] td > div {
+                max-height: unset;
+              }
+            `}
+          >
             {row.getVisibleCells().map((cell) => (
               <Cell key={cell.id}>
                 {flexRender(cell.column.columnDef.cell, cell.getContext())}

diff --git a/src/pages/version/ParametersModal/index.tsx b/src/pages/version/ParametersModal/index.tsx
@@ -42,7 +42,7 @@ export const ParametersModal: React.FC<ParametersProps> = ({ parameters }) => {
         title="Patch Parameters"
       >
         <OverflowContainer>
-          <BaseTable table={table} />
+          <BaseTable table={table} shouldAlternateRowColor />
         </OverflowContainer>
       </DisplayModal>
     </>
@@ -58,11 +58,9 @@ const columns: LGColumnDef<Parameter>[] = [
   {
     accessorKey: "key",
     header: "Key",
-    cell: (value) => value.getValue(),
   },
   {
     accessorKey: "value",
     header: "Value",
-    cell: (value) => value.getValue(),
   },
 ];