encode projectId for backwards compatibility

evergreen-ci · Oct 12, 2023 · 6b8a907 · 6b8a907
1 parent 5f65b76
commit 6b8a907
Showing 1 changed file with 3 additions and 5 deletions.
diff --git a/src/constants/routes.ts b/src/constants/routes.ts
@@ -227,11 +227,9 @@ export const getProjectSettingsRoute = (
   projectId: string,
   tab?: ProjectSettingsTabRoutes
 ) => {
-  if (!tab) {
-    return `${paths.project}/${projectId}/${PageNames.Settings}`;
-  }
-
-  return `${paths.project}/${projectId}/${PageNames.Settings}/${tab}`;
+  const encodedProjectId = encodeURIComponent(projectId);
+  const root = `${paths.project}/${encodedProjectId}/${PageNames.Settings}`;
+  return tab ? `${root}/${tab}` : root;
 };
 
 export const getDistroSettingsRoute = (