Add dependency array

evergreen-ci · Dec 13, 2023 · 65fcd94 · 65fcd94
1 parent 4b4bce0
commit 65fcd94
Show file tree

Hide file tree

Showing 2 changed files with 8 additions and 5 deletions.
diff --git a/src/pages/task/metadata/ETATimer/index.tsx b/src/pages/task/metadata/ETATimer/index.tsx
@@ -27,12 +27,14 @@ const ETATimer: React.FC<ETATimerProps> = ({ expectedDuration, startTime }) => {
         Date.now()
       );
       setEta(newEta > 0 ? newEta : 0);
+      if (newEta <= 0) {
+        clearInterval(timer);
+      }
     }, 1000);
-    if (eta === 0) {
-      clearInterval(timer);
-    }
+
     return () => clearInterval(timer);
-  });
+    // eslint-disable-next-line react-hooks/exhaustive-deps
+  }, []);
 
   return (
     <MetadataItem data-cy="task-metadata-eta">

diff --git a/src/pages/task/metadata/RuntimeTimer/index.tsx b/src/pages/task/metadata/RuntimeTimer/index.tsx
@@ -25,7 +25,8 @@ const RuntimeTimer: React.FC<RuntimeTimerProps> = ({ startTime }) => {
     }, 1000);
 
     return () => clearInterval(timer);
-  });
+    // eslint-disable-next-line react-hooks/exhaustive-deps
+  }, []);
 
   return (
     <MetadataItem data-cy="task-metadata-running-time">