DEVPROD-788: Hide Slack banner more reliably (#2243)

evergreen-ci · Jan 29, 2024 · 349a605 · 349a605
1 parent 7b2e828
commit 349a605
Showing 1 changed file with 3 additions and 2 deletions.
diff --git a/src/components/Banners/SlackNotificationBanner.tsx b/src/components/Banners/SlackNotificationBanner.tsx
@@ -82,9 +82,10 @@ export const SlackNotificationBanner = () => {
     !notifications &&
     (isNotificationSet(patchFirstFailure) || isNotificationSet(patchFinish));
 
-  const showSlackBanner = !hasClosedBanner && !hasSetNotifications;
+  const shouldShowSlackBanner =
+    !defaultSlackUsername && !hasClosedBanner && !hasSetNotifications;
 
-  return showSlackBanner ? (
+  return shouldShowSlackBanner ? (
     <Banner
       variant="info"
       data-cy="slack-notification-banner"