DEVPROD-7742 Fix current testifylint lint issues (manual) #8604
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Kimchelly
reviewed
Jan 10, 2025
| @@ -425,6 +425,7 @@ func TestGetResolvedPlannerSettings(t *testing.T) { | |||
| // Fallback to the SchedulerConfig.ExpectedRuntimeFactor as PlannerSettings.ExpectedRunTimeFactor is equal to 0. | |||
| assert.EqualValues(t, 7, resolved0.ExpectedRuntimeFactor) | |||
| assert.EqualValues(t, 20, resolved0.GenerateTaskFactor) | |||
| //nolint:testifylint // We expect it to be exactly 10. | |||
There was a problem hiding this comment.
Out of curiosity, what does testifylint not like about this + the others? It seems like checking that some output value exactly matches an expected hard-coded value would be a normal thing to do in a test.
There was a problem hiding this comment.
These ones are checking float. Testifylint suggests we use a (I didn't know it existed) InEpsilon assertion/require for floats to account for floating point number errors. I figured since our tests are passing, no reason to modify the behavior to check for a range.
Kimchelly
approved these changes
Jan 13, 2025
ZackarySantana
added a commit
to ZackarySantana/evergreen
that referenced
this pull request
Jan 22, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEVPROD-7742
Description
Before merging in the fix for our linter and adding stricter rules, I'm doing smaller PRs to fix the current mistakes that our linter should be catching.
This PR fixes the testifylint lint issues with manual changes. There weren't that many that autofix didn't fix, but these were the most valuable as it caught some bugs (e.g. we were panicing in some goroutines by using
requirein them, we also had an accidentalassert.Zero(t, 0, <actual_variable>....so it always passed since it was asserting on the constant0).This PR does not add the testifylint to our linters yet, this is blocked on upgrading our go version. The corresponding ticket is DEVPROD-13938.
Testing
Running golangci-lint run in my terminal results in no more lint errors. This pulls from the .golangci.yml file's configuration (which our linter task should be doing.