DEVPROD-13406: silence patch info logs for JSON output #8599
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
… DEVPROD-13406_silence_json_output
Kimchelly
added a commit
to Kimchelly/evergreen
that referenced
this pull request
Jan 9, 2025
evergreen-ci#8599)"" This reverts commit c11a32d.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEVPROD-13406
Description
There's a bunch of grip logs throughout
evergreen patchand it turns out there's actually several non-serious info/warning logs you can hit depending on your local~/.evergreen.ymlsettings and which flags you pass intoevergreen patch. For JSON output, ideally it would only log something as non-JSON if the patch command hits a problem that will cause it to fail and error out. To make it work for the various local config settings/flag combinations, I changed the grip logging setup so that when a user requests JSON output, any non-error grip logs are suppressed entirely, so the user will only see either 1. the successful JSON patch output or 2. a failing error message and a non-zero exit code.evergreen patchonly works if the user has a default project or explicitly sets a project via the CLI flag.Testing
Ran
evergreen patchwith various to verify that--jsonoutput shows a fatal (non-JSON) CLI error if there is one, otherwise it shows only the successful JSON output.Documentation
N/A