DEVPROD-11883: ignore Parameter Store feature flag for GitHub app keys #8594
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEVPROD-11883
Description
Follow-up to #8592 - as part of switching to Parameter Store as the only storage for GitHub app private keys, this will start ignoring the temporary project-level feature flag. Instead, projects will always use Parameter Store for GitHub app private keys without needing me to enable the project-level flag.
Along with this, I noticed that the Spruce e2e tests were failing because they rely on running local-evergreen, which wasn't using the fake Parameter Store implementation (only tests, like
make test-model
, could use it). To ensure local-evergreen can use the fake implementation rather than rely on a real instance of Parameter Store in AWS, I added a testing-environment-only flag so that local-evergreen can use the fake implementation. Staging/prod won't have the testing environment flag enabled, so they won't use the fake implementation.Once this is deployed, I'm gonna monitor for errors.
Testing
Documentation
N/A