Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEVPROD-11883: ignore Parameter Store feature flag for GitHub app keys #8594

Merged

Conversation

Kimchelly
Copy link
Contributor

@Kimchelly Kimchelly commented Jan 6, 2025

DEVPROD-11883

Description

Follow-up to #8592 - as part of switching to Parameter Store as the only storage for GitHub app private keys, this will start ignoring the temporary project-level feature flag. Instead, projects will always use Parameter Store for GitHub app private keys without needing me to enable the project-level flag.

Along with this, I noticed that the Spruce e2e tests were failing because they rely on running local-evergreen, which wasn't using the fake Parameter Store implementation (only tests, like make test-model, could use it). To ensure local-evergreen can use the fake implementation rather than rely on a real instance of Parameter Store in AWS, I added a testing-environment-only flag so that local-evergreen can use the fake implementation. Staging/prod won't have the testing environment flag enabled, so they won't use the fake implementation.

Once this is deployed, I'm gonna monitor for errors.

Testing

  • Existing tests for GitHub app keys (including Spruce e2e tests for GitHub app settings) still pass.
  • Tested in staging that a new project that I did not opt into Parameter Store used Parameter Store for the GitHub app key.

Documentation

N/A

@Kimchelly Kimchelly requested a review from a team January 6, 2025 19:47
@Kimchelly Kimchelly enabled auto-merge (squash) January 9, 2025 16:09
@Kimchelly Kimchelly merged commit 5e0e6e2 into evergreen-ci:main Jan 9, 2025
10 checks passed
@Kimchelly Kimchelly deleted the DEVPROD-11883_gh_app_always_use_ps branch January 9, 2025 17:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants