Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEVPROD-10531 add redact keys to admin page #8581

Merged
merged 1 commit into from
Dec 20, 2024

Conversation

ablack12
Copy link
Contributor

DEVPROD-10531

Description

Add redact keys to the admin page.

Testing

Added a unit test and tested with local:
image

@ablack12 ablack12 requested a review from a team December 19, 2024 22:08
Copy link
Contributor

@hadjri hadjri left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM mod nit and assuming the page looks good when running make local-evergreen

s.NoError(err)
settings, err := GetConfig(ctx)
s.NoError(err)
s.NotNil(settings)
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

nit: require

@ablack12 ablack12 merged commit fd96df4 into evergreen-ci:main Dec 20, 2024
10 checks passed
@ablack12 ablack12 deleted the DEVPROD-10531 branch December 20, 2024 18:07
ZackarySantana pushed a commit to ZackarySantana/evergreen that referenced this pull request Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants