DEVPROD-7742 Add lint rules for constants and body close #8579
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ZackarySantana
changed the title
…ate_token permissions (evergreen-ci#8588)
) Signed-off-by: dependabot[bot] <[email protected]> Co-authored-by: dependabot[bot] <49699333+dependabot[bot]@users.noreply.github.com>
|
I'm redoing this PR since merging main has caused.... 300 files |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEVPROD-7742
Description
This fixes lint rules for
printfwhich should've been caught by our linter but it appears not to be.I also enabled
goconstandbodyclose.goconstmakes it so variables used 3 times require a constant. This can still be negated if not needed. I did some constant things to make it pass.bodycloseis quite useful, it caught a lot of instances where we weren't closing the body.Testing
Run
golangci-lint runon our codebase (iteratively ran this to find the lint breakages until it returned none)