Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEVPROD-8559 Retry on EOF github responses #8572

Merged
merged 2 commits into from
Dec 19, 2024
Merged

DEVPROD-8559 Retry on EOF github responses #8572

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
42604f5
DEVPROD-8559 Retry on EOF github responses
bynn Dec 19, 2024
d276799
log
bynn Dec 19, 2024
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
9 changes: 9 additions & 0 deletions thirdparty/github.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -246,6 +246,15 @@ func githubShouldRetry(caller string, config retryConfig) utility.HTTPRetryFunct
url := req.URL.String()

if err != nil {
if errors.Is(err, io.EOF) || errors.Is(err, io.ErrUnexpectedEOF) {
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM! Should we add a comment with context why we retry on it?

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

hmm I wasn't sure if we would need it but a little log never harmed anyone (maybe)

grip.Error(message.WrapError(err, message.Fields{
"message": "EOF error from github",
"method": req.Method,
"url": url,
"retry_num": index,
}))
return true
}
temporary := utility.IsTemporaryError(err)
grip.Error(message.WrapError(err, message.Fields{
"message": "failed trying to call github",
Expand Down
Loading