Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEVPROD-12742: Add display status to annotations updates #8570

Merged
merged 2 commits into from
Dec 19, 2024

Conversation

sophstad
Copy link
Contributor

@sophstad sophstad commented Dec 18, 2024

DEVPROD-12742 - followup to #8531 et al.

Description

  • For functions that update a task's annotations, also update their display status cache. This required plumbing context through a few functions in order to use task.UpdateOneContext which is needed for an aggregation update operation.

Testing

  • Add check for DisplayStatusCache in tests

@sophstad sophstad requested a review from a team December 18, 2024 21:51
@sophstad sophstad marked this pull request as ready for review December 18, 2024 21:51
@sophstad sophstad changed the title DEVPROD-12742: Add display status annotations updates DEVPROD-12742: Add display status to annotations updates Dec 18, 2024
@@ -2833,7 +2837,6 @@ func abortAndMarkResetTasks(ctx context.Context, filter bson.M, taskIDs []string
AbortedKey: true,
AbortInfoKey: AbortInfo{User: caller},
ResetWhenFinishedKey: true,
DisplayStatusKey: DisplayStatusExpression,
Copy link
Contributor Author

@sophstad sophstad Dec 19, 2024

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This was mistakenly added in #8519 😓 it uses the wrong key name and is redundant due to addDisplayStatusCache in the operation. I will need to run a DB operation to unset the field:

db.tasks.updateMany({}, { $unset: { display_status: 1 } })

@sophstad sophstad merged commit d8949d4 into evergreen-ci:main Dec 19, 2024
10 checks passed
@sophstad sophstad deleted the DEVPROD-12742-annotations branch December 19, 2024 20:23
ZackarySantana pushed a commit to ZackarySantana/evergreen that referenced this pull request Jan 7, 2025
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants