Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEVPROD-8819: make more specific host creation failure event for spawn host outcome #8552

Conversation

Kimchelly
Copy link
Contributor

@Kimchelly Kimchelly commented Dec 12, 2024

DEVPROD-8819

Description

The user subscription for previously listened for host creation errors in general, which would notify them when their spawn host fails to start up (e.g. due to insufficient capacity). However, the way the notification infrastructure works that means all host creation errors have to be processed for notifications, even for non-spawn-hosts. This can put strain on the notification system when lots of hosts are failing to start (e.g. because many task hosts are hitting insufficient capacity).

Since we only want to process notifications for spawn hosts failing to be created, I made a more specific error message.

Testing

  • Added unit tests for triggers.
  • Tested in staging that starting a spawn host (and manually hard-coding an error during host creation) sent me a Slack notification about it failing to start up.

Documentation

N/A

@Kimchelly Kimchelly requested a review from a team December 12, 2024 18:02
@Kimchelly Kimchelly merged commit 55108b6 into evergreen-ci:main Dec 13, 2024
10 checks passed
@Kimchelly Kimchelly deleted the DEVPROD-8819_more_specific_spawn_host_creation_error branch December 13, 2024 19:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants