Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

DEVPROD-5859 Remove commit queue docs #8007

Merged
merged 3 commits into from
Jun 18, 2024

Conversation

bsamek
Copy link
Contributor

@bsamek bsamek commented Jun 18, 2024

DEVPROD-5859

Description

This removes docs for the legacy commit queue. All projects have migrated. I
will not merge this until we remove the UI allowing users to select the commit
queue evergreen-ci/ui#178. I'm waiting on one user to
confirm for me that all looks good, but wanted to prepare this PR.

Testing

N/A, docs only.

Documentation

This!

@bsamek bsamek requested a review from a team June 18, 2024 13:57
Copy link
Contributor

@Kimchelly Kimchelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sorry, GitHub doesn't let me comment on unchanged lines, so all I can do is list out the comments...

@bsamek
Copy link
Contributor Author

bsamek commented Jun 18, 2024

Sorry, GitHub doesn't let me comment on unchanged lines, so all I can do is list out the comments...

Yes. I added some clarifying text.

Fixed.

Fixed.

They do. Fixed.

Removed.

  • merge_test needs to be removed from the Trino docs.

I left that in on the theory that people might still review historical tasks.

  • Are we going to rename the "GitHub & Commit Queue" section in the UI, or is the commit queue part going to stay?

I plan to rename this.

@bsamek bsamek requested a review from Kimchelly June 18, 2024 19:36
Copy link
Contributor

@Kimchelly Kimchelly left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM mod could we mention that merge_test in the Trino docs is deprecated? I believe Trino data also has a TTL, so it'll eventually never appear there either.

Also, so excited to delete this 💣

@bsamek bsamek merged commit f9911ab into main Jun 18, 2024
4 checks passed
@bsamek bsamek deleted the DEVPROD-5859-remove-commit-queue-docs branch June 18, 2024 19:48
@ybrill
Copy link
Contributor

ybrill commented Jun 20, 2024

Drive-by comment (I saw the commit and was curious): do we want to remove the images (like this one)? Or are they still being referenced somewhere?

@bsamek
Copy link
Contributor Author

bsamek commented Jun 20, 2024

Drive-by comment (I saw the commit and was curious): do we want to remove the images (like this one)? Or are they still being referenced somewhere?

@ybrill Ah they should, thanks! Opened #8015

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants