-
Notifications
You must be signed in to change notification settings - Fork 127
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
DEVPROD-5859 Remove commit queue docs #8007
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Sorry, GitHub doesn't let me comment on unchanged lines, so all I can do is list out the comments...
- Is the commit queue alias example still valid?
- The commit queue expansion should say it's true for the merge queue now.
- Is the commit queue requester still valid, or should it be changed to
github_merge_queue
? - Is the task priority for merge queue tasks supposed to be changed to merge queue? Do merge queue tasks get bonus weight in the scheduler?
- Should this thing about parameters and the commit queue be removed/edited?
merge_test
needs to be removed from the Trino docs.- Are we going to rename the "GitHub & Commit Queue" section in the UI, or is the commit queue part going to stay?
Yes. I added some clarifying text.
Fixed.
Fixed.
They do. Fixed.
Removed.
I left that in on the theory that people might still review historical tasks.
I plan to rename this. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM mod could we mention that merge_test
in the Trino docs is deprecated? I believe Trino data also has a TTL, so it'll eventually never appear there either.
Also, so excited to delete this 💣
Drive-by comment (I saw the commit and was curious): do we want to remove the images (like this one)? Or are they still being referenced somewhere? |
DEVPROD-5859
Description
This removes docs for the legacy commit queue. All projects have migrated. I
will not merge this until we remove the UI allowing users to select the commit
queue evergreen-ci/ui#178. I'm waiting on one user to
confirm for me that all looks good, but wanted to prepare this PR.
Testing
N/A, docs only.
Documentation
This!