DEVPROD-4798 deprecate ssh key fields #7725
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
khelif96
approved these changes
Apr 9, 2024
There was a problem hiding this comment.
If the fields aren't set the only effect would be on the UI side, afaik. But for now we'll continue to always set the field on the backend. So does that mean we're safe?
It depends on if the UI is expecting or doing something with those fields. But for now I think we are safe.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
DEVPROD-4798
Description
Step one of removing required GraphQL fields is to make them optional (#7713 (comment)).
I wasn't 100% sure I understood
If the fields aren't set the only effect would be on the UI side, afaik. But for now we'll continue to always set the field on the backend. So does that mean we're safe?