Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Additional email options #40

Open
wants to merge 5 commits into
base: master
Choose a base branch
from
Open

Conversation

etlweather
Copy link
Contributor

  1. Added 2 options for email: encryption and domain. Both were needed for my set up to work.
  2. Removed the validation of the to_email because the way it was, you can't send email to multiple recipients. Without it, you have set the string to '[email protected],[email protected]' and it will send the email to both. I think it would be nicer if it was an array of string as you could then do validation but I couldn't figure out how to loop through an array in Puppet and I ran out of time for this.

@jlambert121
Copy link
Contributor

Would you be able to take care of spec tests? I don't think removing the validations is the way to go, adding the comma to the regex seems to make more sense. Until puppet 4.0 (or parser = future) we won't be able to validate elements in an array so I've left stuff like that off until that becomes more adopted.

@etlweather
Copy link
Contributor Author

spec tests: yeah, I really ought to get set up with that. Let me get myself set up, need to be able to start doing tests. I just started with Puppet and was mostly checking it out and making a proof of concept but at think at this point I'm settled on it so it's worth taking the time.

email list: good point, validating for the comma make more sense.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants