Contain classes #32
Open
Contain classes #32
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
added 2 commits
February 13, 2018 09:43
- found that when used with other modules ordering was difficult, mostly due to:
```
File {
require => Package['artifactory'],
}
```
This commit removes the blanket precedence statement and replaces it with
explicit ordering and containment.
To support mounting an additional volume for hosting artifactory data, it is useful to be able to turn off creation of the artifactory data directory. The default value for `create_data_path` is `true`, therefore under normal conditions existing behaviour is maintained.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I found that when used with other modules ordering was difficult, mostly due to:
This PR removes the above blanket precedence statement and replaces it with
explicit ordering and containment. Furthermore, it adds a
create_data_path=trueparameter to the main class allowing for override to omit creating the data path
directory should it already be being managed by puppet elsewhere in the catalog -
the default ensuring that existing behaviour is preserved.