Merge pull request #247 from stillalivx/master

Fix (#223): In case of insertion, return empty array
eveningkid · Apr 26, 2021 · 0278c27 · 0278c27
2 parents 0133dee + d9edfd8
commit 0278c27
Show file tree

Hide file tree

Showing 2 changed files with 21 additions and 0 deletions.
diff --git a/lib/connectors/sqlite3-connector.ts b/lib/connectors/sqlite3-connector.ts
@@ -76,6 +76,10 @@ export class SQLite3Connector implements Connector {
  };
  }
 
+ if (queryDescription.type === "select") {
+ return [];
+ }
+
  return { affectedRows: this._client.changes };
  }
 

diff --git a/tests/units/queries/sqlite/response.test.ts b/tests/units/queries/sqlite/response.test.ts
@@ -38,6 +38,15 @@ Deno.test("SQLite: Response model", async () => {
  "Insert response",
  );
 
+ const selectResponse = await Article.select("id")
+ .where({ title: "Hello world!" }).get();
+
+ assertEquals(
+ JSON.stringify(selectResponse),
+ JSON.stringify([{ id: 1 }]),
+ "Expected one article",
+ );
+
  const updateResponse = await Article.where({ id: 1 })
  .update({ title: "Hello there!" });
 
@@ -84,5 +93,13 @@ Deno.test("SQLite: Response model", async () => {
  "Delete many records response",
  );
 
+ const selectEmptyResponse = await Article.all();
+
+ assertEquals(
+ JSON.stringify(selectEmptyResponse),
+ JSON.stringify([]),
+ "Select expected empty response",
+ );
+
  await connection.close();
 });