-
-
Notifications
You must be signed in to change notification settings - Fork 720
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Ocpp: provide better support multiple connectors #15762
Conversation
374a6b0
to
3c2ec09
Compare
Wir sollten besser noch if c.conn.NeedsAuthentication() {
if c.remoteStart {
// lock the cable by starting remote transaction after vehicle connected
if err := c.initTransaction(); err != nil {
c.log.WARN.Printf("failed to start remote transaction: %v", err)
}
} else {
// TODO: bring this status to UI
c.log.WARN.Printf("waiting for local authentication")
}
} vom synchronen Charger-Status an den asynchronen StatusNotification-Handler des Connectors verschieben. Sonst gibt es Timeout-Probleme wenn das Dabei kann die Warning auch zu einer einfachen Debug-Message werden. Kann man natürlich auch noch separat im Anschluss machen, passt aber thematisch eigentlich hier hinein. |
Gerne, aber das ist ein separates Thema! |
@premultiply ok von Deiner Seite? |
Ich würde es nachher noch real testen. |
Fix #15559, fix #15677
This PR moves setup procedure from charger (where is is implemented pre connector) to chargepoint where possible. Chargepoints are only initialised once. This should help with various startup/timeout errors.