Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

allow load plugin result with empty loader to have null contents #3532

Open
wants to merge 1 commit into
base: main
Choose a base branch
from

Conversation

clydin
Copy link

@clydin clydin commented Dec 8, 2023

Currently, a plugin that returns a loader value of empty also requires the contents field to be set to a non-null value for the loader to be used. Since the provided contents will never be used in the empty loader case, the contents field is now no longer required in the case when an empty loader is returned. This removes the chance of a plugin unintentionally not using the returned empty loader.

Currently, a plugin that returns a `loader` value of `empty` also
requires the `contents` field to be set to a non-null value for the
loader to be used. Since the provided contents will never be used
in the empty loader case, the `contents` field is now no longer
required in the case when an `empty` loader is returned. This removes
the chance of a plugin unintentionally not using the returned empty
loader.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant