-
Notifications
You must be signed in to change notification settings - Fork 18
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Closes 151 #162
Closes 151 #162
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Currently, there are 3 tests that fail on my end.
In line 50 of utils/trotterization.py there is a troterized_operator
that needs to be replaced by trotterized_operator
. This will fix 2 of the 3 failing tests.
The third failing test is test_freeze_orb_qpe
. I am getting
assert -28.736737051008387 == -28.747184707540754 ± 1.1e-03
Maybe you will need to play with the QPE parameters a little bit to make it pass.
@@ -24,7 +24,9 @@ def run(self, | |||
guess_energy : A guess for the eigenvalue of the eigenspace with which |0>^(n) | |||
has greatest overlap. You should be confident the ground state is within | |||
t : A scaling parameter that controls the precision of the computation. You should | |||
confident that the eigenvalue of interest is within +/- t of the guess energy. | |||
confident that the eigenvalue of interest is within +/- 2pi/t of the guess energy. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replace "confident" by "be confident", or something similar.
@@ -31,3 +31,26 @@ def test_freeze_orb_ucc(self, method, options): | |||
Efci = -28.747184707540754 | |||
|
|||
assert Egs == approx(Efci, abs=1.0e-10) | |||
|
|||
def test_freeze_orb_qkd(self): |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Replace "qkd" by "qpe".
I swear I had the Most of those are trivial, but I'm seeing evidence of another bug in the code. I'll deal with it, although I'm not happy that the situation was this bad. Thanks for catching that something was amiss. |
Description
Closes #151.
User Notes
Checklist