Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

full cmake 4/N: remainder of config.h #313

Open
wants to merge 12 commits into
base: master
Choose a base branch
from

Conversation

loriab
Copy link
Collaborator

@loriab loriab commented Dec 23, 2023

currently atop #312 . diff of the new stuff: loriab/libint@orderingsconfig...loriab:libint:configconfig

  • remaining configure.ac options that feed config.h transferred to cmake, except for dependency options. largely tested to replicate libtool and added to upgrade guide.
  • LIBINT_HOST_ARCH & LIBINT_TARGET_ARCH removed as never used
  • CXX_ALLOWS_DEFPARAMTEMPLATE_AS_TEMPTEMPPARAM left undef as there's no libtool check. are cxx_template_template_parameters (c++98) or cxx_default_function_template_args (c++11) relevant from https://cmake.org/cmake/help/v3.26/prop_gbl/CMAKE_CXX_KNOWN_FEATURES.html ?
  • the LIBINT2_REALTYPE/LIBINT_USER_DEFINED_REAL have a compile-check, and the data transfer seems to hold together, but definitely needs testing with full code. it's only for the C interface?

@loriab loriab marked this pull request as ready for review December 23, 2023 09:08
@loriab loriab mentioned this pull request Dec 25, 2023
14 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant