Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Remove MetopProduct API #5

Merged
merged 1 commit into from
Dec 16, 2024
Merged

Remove MetopProduct API #5

merged 1 commit into from
Dec 16, 2024

Conversation

lupemba
Copy link
Contributor

@lupemba lupemba commented Dec 16, 2024

  • Remove the MetopProduct API. I don't think anyone should use it. Removing it will make the package more focused, easier to document and easier to maintain.
  • Add specific error message for when files have been corrupted with incorrect FTP transfer.
  • Use public keyword to mark un-exported functions that should still be fine to use.
  • Remove comment about DiskArray warning. The warning should disappear in the next DiskArray release. Remove warning for fallback_element_size altogether JuliaIO/DiskArrays.jl#209

@lupemba lupemba requested a review from wilzewski December 16, 2024 14:22
wilzewski
wilzewski approved these changes Dec 16, 2024
View reviewed changes
Copy link
Collaborator

@wilzewski wilzewski left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks good - thanks, Simon!

@lupemba lupemba merged commit 92054c4 into main Dec 16, 2024
10 checks passed
@lupemba lupemba deleted the remove_MetopProduct branch December 16, 2024 15:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@wilzewski wilzewski wilzewski approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lupemba @wilzewski