Specs update after Cantina fixes #267
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
L-03 Missing Docstrings
CR-02 Redeem and Withdraw Might Be Prevented by Enabled Controllers
Signed-off-by: Mick de Graaf <[email protected]>
CR-01 Assets Can be Lost if gulp is Called With Empty Deposit
N-11 Functions Are Updating the State Without Event Emissions
N-09 Incorrect Docstrings
N-08 Gas and Code Improvements
N-06 Non-Explicit Imports Are Used
Signed-off-by: Mick de Graaf <[email protected]>
N-05 Missing Named Parameters in Mapping
N-03 Inconsistent Use of Named Returns
Signed-off-by: Mick de Graaf <[email protected]>
N-01 Function Visibility Overly Permissive
L-02 Incomplete Docstrings
…yz/openzeppelin-synth-fixes-private into openzeppelin-synth-fixes
Cantina docs fixes
Cantina 368: An attacker can plummet a share price when there are little funds in the vault
Cantina 477: Incorrect rounding direction in PegStabilityModule allows attackers to drain the contract
Remove ERC20Collateral, add ERC20EVCCompatible
…into specs-update
dglowinski
previously approved these changes
Aug 12, 2024
kasperpawlowski
dismissed
dglowinski’s stale review
The merge-base changed after approval.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
First merge #262