This repository has been archived by the owner on May 24, 2024. It is now read-only.
Override asset configs for multiple collaterals #186
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…assets (similar to AAVE e-mode)
dglowinski
force-pushed
the
override-asset-configs-multiple-collaterals
branch
from
03a053c to
8ffc774
Compare
hoytech
reviewed
Feb 28, 2023
| liqOpp.yield = collateralBalance; | ||
| } | ||
| if (liqLocs.collateralBalance < liqOpp.yield) { | ||
| liqOpp.repay = liqLocs.collateralBalance * 1e18 / liqOpp.conversionRate; |
There was a problem hiding this comment.
maybe I don't see something, but does liqOpp.repay have to be limited here? although not profitable, if the liquidator wants to repay more than the value of the collateral seized, why do we stop them?
There was a problem hiding this comment.
Possibly we'd want to allow more repay, but I think the place to handle it would be in executeLiquidation. We can discuss it, but I don't think it's in scope
dglowinski
force-pushed
the
override-asset-configs-multiple-collaterals
branch
4 times, most recently
from
967a7ce to
e9a6ca6
Compare
dglowinski
force-pushed
the
override-asset-configs-multiple-collaterals
branch
from
e9a6ca6 to
b835b05
Compare
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.