This repository has been archived by the owner on May 24, 2024. It is now read-only.
Fix: getPriceFull forwarded pricing type #172
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hoytech
added a commit
that referenced
this pull request
Feb 16, 2023
This fix is from Kasper's #172 pull request. This removes an if condition that will never be true. if given asset has PRICINGTYPE__FORWARDED, the resolvePricingConfig function returns the pricingType of the asset the pricing is forwarded to. hence, the pricingType must never be equal to PRICINGTYPE__FORWARDED after the pricing config is resolved.
|
I've merged this change into the following pull request to prevent merge conflicts: |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
if given asset has
PRICINGTYPE__FORWARDED, theresolvePricingConfigfunction returns thepricingTypeof the asset the pricing is forwarded to. hence, thepricingTypemust never be equal toPRICINGTYPE__FORWARDEDafter the pricing config is resolved.