Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow a client to configure/enable its preferred method of SD-JWT-VC signing key resolution. #40

Conversation

dtsiflit
Copy link
Collaborator

Description of change

There are 3 new factory methods that initialize an SDJWTVCVerifier for metadata, X509 certificates and DID.

Type of change

Please delete options that are not relevant.

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the readme
  • My changes generate no new warnings
  • I have added unit tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@dtsiflit dtsiflit self-assigned this Nov 28, 2024
@dtsiflit dtsiflit requested a review from a team as a code owner November 28, 2024 13:36
@dtsiflit dtsiflit merged commit 15f7c0e into eu-digital-identity-wallet:main Nov 28, 2024
2 checks passed
@dtsiflit dtsiflit deleted the feature/sd-jwt-vc-verifier-config-options branch November 28, 2024 13:43
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant