Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat(jose): updated to use a new jose library #24

Conversation

goncalo-frade-iohk
Copy link
Contributor

@goncalo-frade-iohk goncalo-frade-iohk commented Jun 6, 2024

Description of change

This commit updates the code base to use this jose library instead.
Now it uses https://github.com/beatt83/jose-swift that has more features, it also supports JWT.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • Refactor (non-breaking change refactor of internal component)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

This change requires that all the Unit tests continue passing.

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the readme
  • My changes generate no new warnings
  • I have added unit tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@dtsiflit
Copy link
Collaborator

dtsiflit commented Jun 14, 2024

Hello @goncalo-frade-iohk , I'm running the tests on this branch (fastlane tests) and I am getting the following errors within jose-swift:

jose-swift/Sources/JSONWebAlgorithms/KeyManagement/KeyEncryption/AES/AESKeyUnwrap+KeyUnwrap.swift:41:24: 'KeyWrap' is only available in iOS 15.0 or newer

jose-swift/Sources/JSONWebAlgorithms/KeyManagement/KeyEncryption/AES/AESKeyUnwrap+KeyUnwrap.swift:41:32: 'unwrap(_:using:)' is only available in iOS 15.0 or newer

Is there something else I should be doing? Thanks!

Edit: My bad, updating to the latest package versions (3.1.0) works perfectly

This commit updates the code base to use this jose library instead.
@goncalo-frade-iohk
Copy link
Contributor Author

goncalo-frade-iohk commented Jun 14, 2024

@dtsiflit Ive seen the CI was failing because of the swift tools as well. I updated the eudi-lib-sdjwt-swift package for swift tools for 5.8.1 and the minimum version of the jose-swift to 3.1.0 ;)

Package.swift Outdated
exact: "2.4.1-gcm"
),
url: "https://github.com/beatt83/jose-swift.git",
from: "3.0.0"
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Can we use version 3.1.0 please?

@dtsiflit dtsiflit merged commit 6a999d2 into eu-digital-identity-wallet:main Jun 18, 2024
2 checks passed
@dtsiflit
Copy link
Collaborator

Addresses #22

Great work @goncalo-frade-iohk many thanks!

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants