Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Refactor: Improves BottomBarButton padding logic. #32

Conversation

gstamatop
Copy link
Contributor

Description of changes

  • Refactor bottom bar buttons to receive a modifier for padding instead of PaddingValues.
  • Update usages of bottom bar buttons in SuccessScreen, SelectCertificateScreen, and SelectQtspScreen to pass padding via modifier.
  • Update ContentScreen to calculate paddings for sticky bottom content based on screen padding and layout direction.
  • Update ScreenPadding.kt with a new function to calculate sticky bottom paddings.

Type of change

Please delete options that are not relevant.

  • Other fix (maintenance or house-keeping)

How Has This Been Tested?

Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration

  • Test suite run successfully

Checklist:

  • I have performed a self-review of my own code
  • I have commented my code, particularly in hard-to-understand areas
  • I have made corresponding changes to the readme
  • My changes generate no new warnings
  • I have added unit tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes
  • I have checked that my views are accessible
  • I have checked that my strings are localized where applicable

- Refactor bottom bar buttons to receive a modifier for padding instead of PaddingValues.
- Update usages of bottom bar buttons in SuccessScreen, SelectCertificateScreen, and SelectQtspScreen to pass padding via modifier.
- Update ContentScreen to calculate paddings for sticky bottom content based on screen padding and layout direction.
- Update ScreenPadding.kt with a new function to calculate sticky bottom paddings.
@gstamatop gstamatop requested a review from a team as a code owner December 2, 2024 16:41
@stzouvaras stzouvaras merged commit 118bbdf into eu-digital-identity-wallet:main Dec 2, 2024
4 of 5 checks passed
@stzouvaras stzouvaras deleted the refactor/sticky_bottom_rework branch December 2, 2024 17:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants