UI fixes + sticky bottom content rework #17
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Passed padding values to bottom bar buttons to allow for consistent padding.
- Added padding to action text in SelectionItem composable. - Removed icon from SelectionItem composable and SelectionItemUi data class. - Bumped version to 0.0.4-SNAPSHOT.
- Updated ContentScreen to display the toolbar title with a maximum of 2 lines and ellipsis for overflow. - Refactored TextWithBadge to use a Row for layout and improved badge display. - Updated TextWithBadgePreview to use a PreviewParameter for the text length. - Updated TextLengthPreviewProvider to provide different text lengths for previews.
stzouvaras
approved these changes
Nov 21, 2024
stzouvaras
merged commit 7cc2d0b
into
eu-digital-identity-wallet:main
4 of 5 checks passed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description of changes
UI fixes + sticky bottom content rework
Type of change
How Has This Been Tested?
Please describe the tests that you ran to verify your changes. Provide instructions so we can reproduce. Please also list any relevant details for your test configuration
Checklist: