Skip to content

Commit

Permalink
remove HTML generation altogether
Browse files Browse the repository at this point in the history
  • Loading branch information
dslmeinte committed Oct 13, 2022
1 parent 5fef61c commit f975a58
Show file tree
Hide file tree
Showing 13 changed files with 11 additions and 738 deletions.
5 changes: 0 additions & 5 deletions .github/workflows/ci-certlogic-validate.yml
Original file line number Diff line number Diff line change
Expand Up @@ -29,8 +29,3 @@ jobs:
with:
name: gathered-JSON
path: ${{ github.workspace }}/out/*.json
- name: Publish generated HTML
uses: actions/upload-artifact@v2
with:
name: rules-html
path: ${{ github.workspace }}/html
3 changes: 0 additions & 3 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -58,9 +58,6 @@ To execute the tests on the rules of a specific rule set, or even a specific rul

### Miscellaneous tools

_HTML generation_ generates a HTML page for all rule sets in the directory `html/`.
Those generated HTML pages are also exported as an artifact of the “Validation and Testing of Rule Sets” GitHub Action.

When a rule's `ValidFrom` changes, the tests for that rule might have to be updated as well: the verification timestamp in `external.validationClock` has to be between the indicated `ValidFrom` and `ValidUntil` - its validity range.
Updating the tests can be quite tedious.
To help with that, you can use the `auto-update-test-dates` Node.js program, as follows (from `tooling/`):
Expand Down
1 change: 0 additions & 1 deletion html/.gitignore

This file was deleted.

95 changes: 0 additions & 95 deletions html/styling.css

This file was deleted.

2 changes: 0 additions & 2 deletions tooling/build.sh
Original file line number Diff line number Diff line change
Expand Up @@ -13,13 +13,11 @@ echo "Downloading JSON Schema for rules..."
curl https://raw.githubusercontent.com/eu-digital-green-certificates/dgc-gateway/main/src/main/resources/validation-rule.schema.json > schemas/validation-rule.schema.json

OUT_DIR=../out
HTML_DIR=../html

echo "Cleaning..."
npm run clean
rm -rf $OUT_DIR
mkdir -p $OUT_DIR
rm -rf $HTML_DIR/*.html

npm install
npm dedupe
Expand Down
Loading

0 comments on commit f975a58

Please sign in to comment.