Fix getExternalProductItem for softdeletes models #25
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
niekbr
approved these changes
Oct 27, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
De if statements is nu false op de TesLAN website omdat die niet goed werkt. Hierdoor zijn een paar payments to service gefaalt bij payments die lang duurden (heb voor nu via tinker gerestored en de job geretried)
https://finances.thor.edu/horizon/failed/86a5c348-89c1-4204-aa08-60a09e8686b1
https://finances.thor.edu/horizon/failed/4c733cf9-5ba6-45ad-8a82-4e74b8e50463
Ik zal zo op de TesLAN website ook wat testcases hiervoor maken, zodat dit niet opnieuw stuk kan gaan