Uring cmd #2
Draft
Uring cmd #2
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is required to ensure the msghdr is stable over the lifetime of the operation
ollie-etl
commented
Aug 16, 2023
src/io/uring_cmd.rs
Outdated
Comment on lines
6
to
11
| pub(crate) struct UringCmd16 { | ||
| /// Holds a strong ref to the FD, preventing the file from being closed | ||
| /// while the operation is in-flight. | ||
| #[allow(dead_code)] | ||
| fd: SharedFd, | ||
| } |
There was a problem hiding this comment.
Suggested change
| pub(crate) struct UringCmd16 { | |
| /// Holds a strong ref to the FD, preventing the file from being closed | |
| /// while the operation is in-flight. | |
| #[allow(dead_code)] | |
| fd: SharedFd, | |
| } | |
| pub(crate) struct UringCmd16<T)> { | |
| /// Holds a strong ref to the FD, preventing the file from being closed | |
| /// while the operation is in-flight. | |
| #[allow(dead_code)] | |
| fd: SharedFd, | |
| // Holds side channel data for the duration of the operation | |
| // This allows the construction of safe apis | |
| t: T | |
| } |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.