Set external IP and mapping port to es-node ENR when it behind a NAT and the advertise IP is not set #132
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
qzhodl
reviewed
Dec 5, 2023
ethstorage/p2p/discovery.go
Outdated
| @@ -149,6 +166,30 @@ func (v *Secp256k1) DecodeRLP(s *rlp.Stream) error { | |||
| return nil | |||
| } | |||
|
|
|||
| func addNATMappings(tcpPort, udpPort int) (net.IP, int, int, error) { | |||
There was a problem hiding this comment.
We may want to investigate whether libp2p can do this work if we enable NAT option in the libp2p constructor
There was a problem hiding this comment.
NAT manager is not public, we cannot directly use it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Issue: #131
If the es-node is running behind a NAT and without the advertiseIP being set. we can discover the NAT service and add port mappings to the NAT service, then add the external IP and mapping ports to ENR.
How to test:
Run the es-node behind NAT service without advertiseIP being set. Then copy the ENR the es-node output and check it in the https://enr-viewer.com/.
enr:-Li4QCVR_onX8sRp5LVSxHTMbxIkvJVcS3VXu9c3DcFBhnrjK4YmZHc55Mhktqi9Qj-ypbbUms_u56PyrXbBT2po7CCGAYwvPP-9imV0aHN0b3JhZ2XbAYDY15Sfn1_YmtZI8sAAyVTY2ch3QyQ-xcGAgmlkgnY0gmlwhEmqKEKJc2VjcDI1NmsxoQP9Mik329t5ntsy0m8DWu-JRgT6T1TNOCx_M62HV9GPCIN0Y3CCggGDdWRwgnZcwe can see its multiaddr like
run the second es-node with the first es-node ENR and see the log like the following