Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add json content handler for /forks #136

Merged
merged 6 commits into from
Oct 7, 2024

Conversation

0xTylerHolmes
Copy link
Contributor

I've been using Dora for some testing and really like exposing the /forks page to allow dumping the forks as JSON. I would be eager to have this merged. Do you have any recommendations?

handlers/forks.go Outdated Show resolved Hide resolved
@pk910
Copy link
Member

pk910 commented Oct 7, 2024

Heya @0xTylerHolmes, thanks for your PR.
I think it looks fine for this page :)

These page models are normally not intended to be served as json, because they contain sensitive information in other pages.
However, for the forks page it's fine, but we might change it in future if we add proper api routes.

@pk910 pk910 merged commit fda0d4c into ethpandaops:master Oct 7, 2024
3 checks passed
@0xTylerHolmes 0xTylerHolmes deleted the forkdata_json branch October 7, 2024 22:20
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants