Feature/prime sdk based service hooks #60
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…erspot prime, fixed example dapp
…s, fixed tests accordingly, updated example dapp
IAmKio
reviewed
Oct 24, 2023
| "buffer": "^6.0.3", | ||
| "ethers": "^5.6.9", | ||
| "etherspot": "^1.41.2", |
IAmKio
requested changes
Oct 24, 2023
| const raw = window.localStorage.getItem(`session-prime-${walletAddress}`); | ||
| result = raw ? JSON.parse(raw) : null | ||
| } catch (err) { | ||
| // |
There was a problem hiding this comment.
We should add a warning or something here should the device or security not allow local storage, feels like a showstopper?
There was a problem hiding this comment.
session storage removed completely per SDK team feedback
IAmKio
previously approved these changes
Oct 24, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Added Changes
exampleReact code to latest changes@etherspot/prime-sdkto version1.3.4Breaking Changes
etherspotdependency@etherspot/react-etherspotdependencyproviderprop as required for<EtherspotTransactionKit />componentgetSdkForChainIdonuseEtherspothook replaced withgetSdkthat returnsPrime SDKinstance asPromiseconnectonuseEtherspotis no longer available and not required to start SDK sessionaccountAddressandproviderWalletAddressare no longer onuseEtherspothook, please useuseWalletAddresshooksdkonuseEtherspothook is no longer present, please usegetSdkonuseEtherspothook