Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feature/prime sdk as default #57

Merged
merged 14 commits into from
Oct 18, 2023
Merged

Feature/prime sdk as default #57

merged 14 commits into from
Oct 18, 2023

Conversation

poocart
Copy link
Contributor

@poocart poocart commented Oct 17, 2023

Breaking Changes

  • Removed etherspot wallet type from useWalletAddress hook
  • Removed via prop from <EtherspotBatches /> component
  • Default useWalletAddress and <EtherspotBatches /> provider is set to etherspot-prime

if (!sdkForChainId) return;

sdkForChainId.clearGatewayBatch();
await etherspotPrimeSdkForChainId.clearUserOpsFromBatch();
}))));
Copy link
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

We definitely need a discussion on the code style at some point

IAmKio
IAmKio previously approved these changes Oct 18, 2023
Copy link
Contributor

@IAmKio IAmKio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM RIP Etherspot V1

@poocart poocart merged commit 4a89c33 into master Oct 18, 2023
3 checks passed
@poocart poocart deleted the feature/prime-sdk-as-default branch October 18, 2023 10:33
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Development

Successfully merging this pull request may close these issues.

2 participants