Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

fix/PRO-2387/update-prime-sdk #147

Merged
merged 13 commits into from
May 22, 2024
Merged

fix/PRO-2387/update-prime-sdk #147

merged 13 commits into from
May 22, 2024

Conversation

RanaBug
Copy link
Contributor

@RanaBug RanaBug commented May 17, 2024 •
edited
Loading

Description

  • Update of the Prime SDK version in Transaction Kit, with 3 new added functions 'getQuotes', 'getTransactionStatus' and 'getSupportedAssets'

How Has This Been Tested?

  • These functions have been tested in the App example, and also using JEST

Screenshots (if appropriate):

Types of changes

  • [x ] New feature (non-breaking change which adds functionality)

@linear Linear
Copy link

linear bot commented May 17, 2024

PRO-2387 TransactionKit / PrimeSDK Update

@RanaBug RanaBug self-assigned this May 17, 2024
@github-actions GitHub Actions
Copy link

Yooo! You forgot to bump the version in package.json!

@RanaBug
Copy link
Contributor Author

RanaBug commented May 17, 2024

In progress...

@github-actions GitHub Actions
Copy link

Yooo! You forgot to bump the version in package.json!

@RanaBug RanaBug force-pushed the fix/PRO-2387/update-prime-sdk branch from 1ba5d78 to de25474 Compare May 20, 2024 15:29
@github-actions GitHub Actions
Copy link

Yooo! You forgot to bump the version in package.json!

@github-actions GitHub Actions
Copy link

Yooo! You forgot to bump the version in package.json!

@github-actions GitHub Actions
Copy link

Yooo! You forgot to bump the version in package.json!

@github-actions GitHub Actions
Copy link

Yooo! You forgot to bump the version in package.json!

@RanaBug RanaBug marked this pull request as ready for review May 21, 2024 16:57
@RanaBug RanaBug requested a review from IAmKio May 21, 2024 16:57
IAmKio
IAmKio requested changes May 21, 2024
View reviewed changes
Copy link
Contributor

@IAmKio IAmKio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Absolutely fantastic work - just a few suggestions and minor code cleanup and we're good to go 🚀

package.json Outdated Show resolved Hide resolved
src/hooks/useEtherspotHistory.ts Outdated Show resolved Hide resolved
src/hooks/useEtherspotHistory.ts Outdated Show resolved Hide resolved
src/hooks/useEtherspotSwaps.ts Outdated Show resolved Hide resolved
__tests__/hooks/useEtherspotHistory.test.js Outdated Show resolved Hide resolved
IAmKio
IAmKio approved these changes May 22, 2024
View reviewed changes
Copy link
Contributor

@IAmKio IAmKio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🚀

@RanaBug RanaBug merged commit f14c03d into master May 22, 2024
5 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IAmKio IAmKio IAmKio approved these changes

Assignees

@RanaBug RanaBug

Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@RanaBug @IAmKio