Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added fixes for estimation cost and error parsing #109

Merged
merged 1 commit into from
Feb 28, 2024
Merged

added fixes for estimation cost and error parsing #109

merged 1 commit into from
Feb 28, 2024

Conversation

poocart
Copy link
Contributor

@poocart poocart commented Feb 28, 2024 •
edited
Loading

Description

  • Updated useEtherspotTransactions hook's estimate and send methods to return actual gas cost on estimated key and nicer error messages on errorMessage key
  • Changed return type to JSX.Element for EtherspotApprovalTransaction, EtherspotContractTransaction and EtherspotTokenTransferTransaction components

How Has This Been Tested?

  • Local dapp and tests.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@poocart poocart requested a review from IAmKio February 28, 2024 07:29
IAmKio
IAmKio approved these changes Feb 28, 2024
View reviewed changes
Copy link
Contributor

@IAmKio IAmKio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@poocart poocart merged commit 166334f into master Feb 28, 2024
5 checks passed
@poocart poocart deleted the fix/transaction-error-and-estimatation-fixes branch February 28, 2024 08:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IAmKio IAmKio IAmKio approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@poocart @IAmKio