Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

added token decimals to token related components #102

Merged
merged 2 commits into from
Feb 22, 2024
Merged

added token decimals to token related components #102

merged 2 commits into from
Feb 22, 2024

Conversation

poocart
Copy link
Contributor

@poocart poocart commented Feb 21, 2024

Description

  • Added missing tokenDecimals param to <EtherspotTokenTransferTransaction /> and <EtherspotApprovalTransaction /> components

How Has This Been Tested?

  • Unit tests.

Screenshots (if appropriate):

Types of changes

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to change)

@poocart poocart marked this pull request as ready for review February 21, 2024 21:06
@poocart poocart requested a review from IAmKio February 21, 2024 21:07
IAmKio
IAmKio approved these changes Feb 22, 2024
View reviewed changes
Copy link
Contributor

@IAmKio IAmKio left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 🍕

@poocart poocart merged commit 691fa40 into master Feb 22, 2024
5 checks passed
@IAmKio IAmKio deleted the feature/token-decimals-on-token-components branch May 21, 2024 20:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@IAmKio IAmKio IAmKio approved these changes

Assignees
No one assigned
Labels
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@poocart @IAmKio