Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

test: unskip TestWithBlocklistStreams test #4912

Merged
merged 1 commit into from
Nov 28, 2024
Merged

test: unskip TestWithBlocklistStreams test #4912

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
18 changes: 10 additions & 8 deletions pkg/p2p/libp2p/connections_test.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -433,7 +433,8 @@ func TestDoubleConnectOnAllAddresses(t *testing.T) {
notifier: mockNotifier(noopCf, noopDf, true),
libp2pOpts: libp2p.Options{
FullNode: true,
}})
},
})
addrs, err := s1.Addresses()
if err != nil {
t.Fatal(err)
Expand Down Expand Up @@ -1019,7 +1020,6 @@ func TestWithDisconnectStreams(t *testing.T) {

func TestWithBlocklistStreams(t *testing.T) {
t.Parallel()
t.Skip("this test always fails")

ctx, cancel := context.WithCancel(context.Background())
defer cancel()
Expand Down Expand Up @@ -1369,9 +1369,11 @@ type (
reachableFunc func(swarm.Address, p2p.ReachabilityStatus)
)

var noopCf = func(context.Context, p2p.Peer, bool) error { return nil }
var noopDf = func(p2p.Peer) {}
var noopAnnounce = func(context.Context, swarm.Address, bool) error { return nil }
var noopAnnounceTo = func(context.Context, swarm.Address, swarm.Address, bool) error { return nil }
var noopReachability = func(p2p.ReachabilityStatus) {}
var noopReachable = func(swarm.Address, p2p.ReachabilityStatus) {}
var (
noopCf = func(context.Context, p2p.Peer, bool) error { return nil }
noopDf = func(p2p.Peer) {}
noopAnnounce = func(context.Context, swarm.Address, bool) error { return nil }
noopAnnounceTo = func(context.Context, swarm.Address, swarm.Address, bool) error { return nil }
noopReachability = func(p2p.ReachabilityStatus) {}
noopReachable = func(swarm.Address, p2p.ReachabilityStatus) {}
)
Loading