Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: gsoc subscribe #4901

Merged
merged 61 commits into from
Nov 18, 2024
Merged

feat: gsoc subscribe #4901

merged 61 commits into from
Nov 18, 2024

Conversation

istae
Copy link
Member

@istae istae commented Nov 11, 2024 •
edited
Loading

Checklist

  • I have read the coding guide.
  • My change requires a documentation update, and I have done it.
  • I have added tests to cover my changes.
  • I have filled out the description and linked the related issues.

Description

TODOs:

  • disable pinning and deferred uploads in soc api @acha-bill
  • chunkstore replace unit tests @acha-bill
  • beekeeper check

builds on top of #4727

Open API Spec Version Changes (if applicable)

Motivation and Context (Optional)

Related Issue (Optional)

Screenshots (if appropriate):

nugaon added 30 commits November 11, 2024 18:50
@nugaon @istae
feat: gsoc
d6836dc
@nugaon @istae
feat: add gsoc listener to pull and pushsync
7378e32
@nugaon @istae
feat: gsoc subscribe api
8baba8d
@nugaon @istae
fix: gsoc address path parsing
3f80697
@nugaon @istae
test: gsoc as param for testServer
e95fbd7
@nugaon @istae
test: gsoc api
4951d6f
@nugaon @istae
test: add empty function for so clisten in pushsync t
455cf73
@nugaon @istae
refactor: remove unused pusher
b970494
@nugaon @istae
docs: gsoc openapi
e07b696
@nugaon @istae
test: unit
ee12d03
@nugaon @istae
docs: fix yaml indentation
858ff26
@nugaon @istae
feat: add new error handling
d979ee5
@nugaon @istae
feat: logger in gsoc listener
e58b7e7
@nugaon @istae
refactor: handle instead of handler
713a985
@nugaon @istae
docs: copypastes
3008299
@nugaon @istae
refactor: rename register to subscribe
36624ef
@nugaon @istae
refactor: unnecessary go call on gsoc handler
99b5e1f
@nugaon @istae
feat: identity address in pull sync
6744b5f
@nugaon @istae
test: multiple payload push
bb0909a
@nugaon @istae
test: gsoc listener
fca83e6
@nugaon @istae
fix: param mismatch after rebasing
3284476
@nugaon @istae
fix: idAddress in pushsync where it is needed
37378e5
@nugaon @istae
test: working signature for pushsync
25bb9bd
@nugaon @istae
refactor: log id_address on push failiure
1178a90
@nugaon @istae
feat: id address usage on pusher and its inflight handling
837563d
@nugaon @istae
fix: remove unnecessary stamp higher condition
f5ad179
@nugaon @istae
fix: reserve put
80858f4
@nugaon @istae
fix: important reserve changes same ps index
de65176
@nugaon @istae
fix: lock by batch id and stamp
009b827
@nugaon @istae
fix: new multex to lock reserve put
73203b5
@istae istae marked this pull request as ready for review November 11, 2024 20:15
martinconic
martinconic approved these changes Nov 12, 2024
View reviewed changes
Copy link
Contributor

@martinconic martinconic left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I do not fully understand the logic in the reserve and maybe we should go through it all together, but all else LGTM

@acha-bill acha-bill mentioned this pull request Nov 12, 2024
Merged
4 tasks
gacevicljubisa
gacevicljubisa approved these changes Nov 12, 2024
View reviewed changes
pkg/postage/stamper.go Show resolved Hide resolved
pkg/storage/storage.go Show resolved Hide resolved
@istae istae merged commit a276067 into master Nov 18, 2024
14 checks passed
@istae istae deleted the gsoc-subscribe branch November 18, 2024 12:28
@istae istae mentioned this pull request Nov 25, 2024
Closed
4 tasks
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@acha-bill acha-bill acha-bill approved these changes

@gacevicljubisa gacevicljubisa gacevicljubisa approved these changes

@martinconic martinconic martinconic approved these changes

@nugaon nugaon Awaiting requested review from nugaon

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@istae @martinconic @gacevicljubisa @acha-bill @nugaon