perf: sampler optimization #4882
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
istae
requested review from
acha-bill,
martinconic,
gacevicljubisa,
nugaon and
zelig
martinconic
approved these changes
Oct 30, 2024
acha-bill
approved these changes
Oct 30, 2024
gacevicljubisa
approved these changes
Oct 30, 2024
nugaon
approved these changes
Oct 31, 2024
| @@ -130,6 +130,22 @@ func (s *SOC) Sign(signer crypto.Signer) (swarm.Chunk, error) { | |||
| return s.Chunk() | |||
| } | |||
|
|
|||
| // UnwrapCAC extracts the CAC inside the SOC. | |||
| func UnwrapCAC(sch swarm.Chunk) (swarm.Chunk, error) { | |||
There was a problem hiding this comment.
sch = soc.FromChunk and sch.WrappedChunk() is not that performant?
There was a problem hiding this comment.
if so, I think later the chunk types could be refactored to serialize/deserialize chunk data only once trough one parent aggregation connection or interface.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Checklist
Description
Cpu profiling revealed that the unnecessary crypto recovery inside soc.FromChunk was the bottleneck.
Open API Spec Version Changes (if applicable)
Motivation and Context (Optional)
Related Issue (Optional)
Screenshots (if appropriate):