Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: allow concurrent use of the same issuer #4263

Merged
merged 4 commits into from
Aug 22, 2023
Merged

Conversation

acha-bill
Copy link
Contributor

Checklist

  • I have read the coding guide.
  • My change requires a documentation update, and I have done it.
  • I have added tests to cover my changes.
  • I have filled out the description and linked the related issues.

Description

Revert stamp issuer to its previous implementation that allowed concurrent use of the same issuer.

Open API Spec Version Changes (if applicable)

Motivation and Context (Optional)

Related Issue (Optional)

Screenshots (if appropriate):

Copy link
Contributor

@aloknerurkar aloknerurkar left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Apart from the minor comment and lint issues, LGTM!

pkg/postage/service.go Outdated Show resolved Hide resolved
@acha-bill acha-bill merged commit a4d90e1 into master Aug 22, 2023
13 checks passed
@acha-bill acha-bill deleted the revert-issuer branch August 22, 2023 13:59
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants