[EigenLayer Slashing] (1) update EtherFiRestaker, (2) fixes in EtherFiNode #222
+155
−262
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Signed-off-by: Jacob T Firek <[email protected]>
…n value in ETH via Liquifier
seongyun-ko
changed the title
…aimer-for-restaker Signed-off-by: syko <[email protected]>
Set claimer for stETH restaking rewards
solipsis
reviewed
Dec 31, 2024
src/EtherFiRestaker.sol
Outdated
|
|
||
| IRewardsCoordinator public immutable rewardsCoordinator; |
There was a problem hiding this comment.
I believe removing the mapping and then declaring this new variable as immutable causes a storage issue since the immutable variable won't be in storage. There will be a conflict for the next storage variable we add in a future upgrade
There was a problem hiding this comment.
makes sense. we can keep the mapping variable putting DEPRECATED_ prefix
solipsis
reviewed
Dec 31, 2024
src/EtherFiRestaker.sol
Outdated
| // shares: sharesArr, | ||
| // withdrawer: address(this) | ||
| // }); | ||
| function _queueWithdrawlsByShares(address _token, uint256 _shares) internal returns (bytes32[] memory) { |
There was a problem hiding this comment.
typo Withdrawls -> Withdrawals
solipsis
approved these changes
Dec 31, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
splitBalanceInExecutionLayer, convert the share amount to the underlying asset amount_queueEigenpodFullWithdrawal, convert the share amount to the underlying asset amount + withdraw the full amount if it is the last validator of the podwithdrawalRootToWithdrawal. the upgrade will be performed when there is no queued withdrawal.withdrawalRootsSetto help track the queued withdrawalsquoteByFairValuewhere neededselClaimerFor