Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Super Optimized Auction Manager #220

Open
wants to merge 3 commits into
base: master
Choose a base branch
from
Open

Conversation

shivam-ef
Copy link

Gas Optimization: Smarter Bid Management in Auction System

Overview

This PR introduces a more efficient way to handle bids in our auction system. By grouping bids together and using a clever tracking system based on bit manipulation, we significantly reduce gas costs for our users while maintaining all functionality, thanks to @solipsis for the great optimization technique.

Why This Matters

  • Lower gas costs for users creating and managing bids
  • More efficient contract operations
  • Better scalability for the platform
  • Maintains same user experience with better performance

Impact on Users

  • Lower transaction costs for bid creation
  • No changes to user interface or experience
  • All existing bids continue to work as before

Copy link
Contributor

@seongyun-ko seongyun-ko left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

can u modify the auction manager contract in-place so that we can see the diff for the upgrade

@solipsis
Copy link
Contributor

it looks like the popcount library is unused since it looks like you decided not to implement the bulk bid accepting. (which is fine, I know bulk accepting requires more changes to the interface). I just want to make sure that matches your expectations

@shivam-ef
Copy link
Author

it looks like the popcount library is unused since it looks like you decided not to implement the bulk bid accepting. (which is fine, I know bulk accepting requires more changes to the interface). I just want to make sure that matches your expectations

Ohh I must have missed it, will take a look today

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants