weETH withdrawal: Instant withdrawal with Fee + Implicit withdrawal fee handling #207

seongyun-ko · 2024-12-09T08:41:43Z

Features

Instant Withdrawal with Fee
- Contract: EtherFiWithdrawalBuffer
- (1) rate limits, (2) low-water mark mechanism, (3) fee & split configuration
Handling of the unburned shares during the delayed withdrawal
- Contract: WithdrawRequestNFT
- the existing delayed withdrawal system had a bug in tracking the dust share amount.
- This PR (1) fixes the bug, (2) adds the function to handle the accumulated dust, and (3) adds the fee split logic

src/EtherFiWithdrawalBuffer.sol

…dity pool, add tests

…sts, add deploy script

src/WithdrawRequestNFT.sol

shivam-ef

LGTM

src/WithdrawRequestNFT.sol

…Withdraw} to account with 'totalLockedEEthShares', (3) simplify 'seizeRequest', (4) handle some issues

src/EtherFiWithdrawalBuffer.sol

src/WithdrawRequestNFT.sol

test/WithdrawRequestNFT.t.sol

src/EtherFiRedemptionManager.sol

Signed-off-by: Jacob T Firek <[email protected]>

…ove unused file

…eSumEEthShareAmount' again after the scan is completed, (3) prevent from undoing the finalization 'finalizeRequests'

…lid param & calling it twice

…rWithdrawal, (2) remove unused function reduceEthAmountLockedForWithdrawal

seongyun-ko added 2 commits December 6, 2024 13:03

init. Instant Withdrawal via Buffer

d356cc9

implemented instant fee mechanism, handling of the implicit fee

82fab2e

seongyun-ko requested a review from jtfirek December 9, 2024 08:41

fix scripts

0f13953

jtfirek reviewed Dec 14, 2024

View reviewed changes

src/EtherFiWithdrawalBuffer.sol Outdated Show resolved Hide resolved

seongyun-ko added 2 commits December 17, 2024 14:43

add role registry, consider eth amount locked for withdrawal in liqui…

0b68310

…dity pool, add tests

use setter for 'shareRemainderSplitToTreasuryInBps', add more fuzz te…

c9fd604

…sts, add deploy script

seongyun-ko requested a review from shivam-ef December 19, 2024 07:41

jtfirek reviewed Dec 19, 2024

View reviewed changes

src/WithdrawRequestNFT.sol Show resolved Hide resolved

jtfirek reviewed Dec 19, 2024

View reviewed changes

src/WithdrawRequestNFT.sol Outdated Show resolved Hide resolved

jtfirek reviewed Dec 19, 2024

View reviewed changes

src/WithdrawRequestNFT.sol Outdated Show resolved Hide resolved

seongyun-ko changed the title ~~Addition of Instant Withdrawal with Fee + handling of unburnt shares from delayed withdrawals~~ Instant Withdrawal with Fee + handling of unburnt shares from delayed withdrawals Dec 20, 2024

seongyun-ko added 2 commits December 20, 2024 10:24

handle issues in calculating the dust shares

c377e8e

improve comments

a3aeac9

seongyun-ko force-pushed the syko/feature/instant_withdrawal branch from 1dbd966 to a3aeac9 Compare December 20, 2024 01:31

seongyun-ko requested review from vvalecha519 and jtfirek December 20, 2024 15:11

shivam-ef approved these changes Dec 23, 2024

View reviewed changes

src/WithdrawRequestNFT.sol Outdated Show resolved Hide resolved

seongyun-ko added 5 commits December 24, 2024 09:27

add sorted & unique constraints + type change to reduce gas

57bd0fc

update 'handleAccumulatedShareRemainder' to be callable by admin

b6100b6

Certora audit: (1) add {aggregateSumEEthShareAmount}, (2) fix {_claim…

e8734d6

…Withdraw} to account with 'totalLockedEEthShares', (3) simplify 'seizeRequest', (4) handle some issues

wip: to be amended

71ffa8d

add simplified {invalidate, validate} request, fix unit tests

9e0fb99

seongyun-ko changed the title ~~Instant Withdrawal with Fee + handling of unburnt shares from delayed withdrawals~~ weETH withdrawal: Instant withdrawal with Fee + Implicit withdrawal fee handling Dec 30, 2024

seongyun-ko added 2 commits December 30, 2024 18:09

rename EtherFiWithdrawBuffer -> EtherFiRedemptionManager

98f483a

fix the logic to check the aggr calls

bcc1184

jtfirek reviewed Dec 30, 2024

View reviewed changes

src/EtherFiWithdrawalBuffer.sol Outdated Show resolved Hide resolved

jtfirek reviewed Dec 30, 2024

View reviewed changes

src/WithdrawRequestNFT.sol Show resolved Hide resolved

jtfirek reviewed Dec 30, 2024

View reviewed changes

test/WithdrawRequestNFT.t.sol Outdated Show resolved Hide resolved

jtfirek reviewed Dec 30, 2024

View reviewed changes

src/EtherFiRedemptionManager.sol Outdated Show resolved Hide resolved

jtfirek and others added 2 commits December 30, 2024 17:14

Update test/WithdrawRequestNFT.t.sol

1f85fb6

Signed-off-by: Jacob T Firek <[email protected]>

reduce gas spending for 'call', update the upgrade init function, rem…

bdee463

…ove unused file

jtfirek approved these changes Dec 30, 2024

View reviewed changes

seongyun-ko added 17 commits December 31, 2024 08:10

apply gas opt for BucketLimiter

d40a117

improve assetion tsets, apply design pattern, function rename

f4f2ffd

apply CEI pattern to 'handleRemainder'

5069c14

apply CEI pattern to 'redeem'

2e13202

use 'totalRemainderEEthShares' instead of locked share

b18bd18

initializeOnUpgrade cant be called twice

1e12673

initializeOnUpgrade onlyOnce

c14c348

use uint256 instead of uint32

35fba66

revert

e95cfc0

improve the fuzz test

bbf2d83

(1) pause the contract on upgrade, (2) prevent from calling 'aggregat…

2cbbc04

…eSumEEthShareAmount' again after the scan is completed, (3) prevent from undoing the finalization 'finalizeRequests'

only owner of the funds can call {redeemEEth, redeemWeEth}

1482cb0

disable unpause until the scan is completed

8ced81e

check the basis points params are below 1e4

86ac4a0

disallow calling 'initializeOnUpgradeWithRedemptionManager' with inva…

1e8cdea

…lid param & calling it twice

(1) withdrawRequestNFT cannot call LiquidityPool.addEthAmountLockedFo…

6fffba6

…rWithdrawal, (2) remove unused function reduceEthAmountLockedForWithdrawal

prevent finalizing future requests

89db9d5

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

weETH withdrawal: Instant withdrawal with Fee + Implicit withdrawal fee handling #207

weETH withdrawal: Instant withdrawal with Fee + Implicit withdrawal fee handling #207

seongyun-ko commented Dec 9, 2024 •

edited

Loading

shivam-ef left a comment

weETH withdrawal: Instant withdrawal with Fee + Implicit withdrawal fee handling #207

Are you sure you want to change the base?

weETH withdrawal: Instant withdrawal with Fee + Implicit withdrawal fee handling #207

Conversation

seongyun-ko commented Dec 9, 2024 • edited Loading

Features

shivam-ef left a comment

Choose a reason for hiding this comment

seongyun-ko commented Dec 9, 2024 •

edited

Loading