-
Notifications
You must be signed in to change notification settings - Fork 25
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Switch all hex to bytes conversions to ethjs equivalents #632
Conversation
Thanks for the PR. I'm not 100% sure what all you were working on here but this shouldn't require updating any dependencies (notably eslint and related plugins) and there should be no updates to docs. This is purely changing the Notably, if you want to continue with this, it should be pretty close a simple "find/replace" across 3 main packages ( Let me know if you want to continue on this one. |
bb44d67
to
14a6cb5
Compare
I will continue working on this one, thank you for explaining. |
fixing tests Revert "Switch all hex to bytes conversions to ethjs equivalents" This reverts commit 040ff32933c5a9fb178d224c71f793fc25e2f1da.
0d2ca48
to
a3db2aa
Compare
Currently passing portalnetwork test and integration test, cli test still have 1 failed test. I'm not sure how to proceed from here. Here is the failed cli test case: ``` FAIL test/rpc/portal/beaconLocalContent.spec.ts > portal_beaconLocalContent tests > should not find any local content AssertionError: expected -32603 to equal -32009 - Expected + Received - -32009 + -32603 ❯ test/rpc/portal/beaconLocalContent.spec.ts:20:12 18| ), 19| ]) 20| assert.equal(res.error.code, -32009) | ^ 21| ultralight.kill(9) 22| }, 10000) ```
Currently it's passing portalnetwork test and integration test, cli test still have 1 failed test. I'm not sure how to proceed from here. Here is the failed cli test case:
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Regarding the hex / bytes conversion functions --
hexToBytes
and bytesToHex
must be imported from @ethereumjs/util
. There are several files in which you are attempting to import these from other libraries.
any other changes (such as to package.json
) should be reverted. keep the scope of this PR limited to the conversion functions.
@@ -11,9 +11,8 @@ import { | |||
NodeLookup, | |||
PingPongCustomDataType, | |||
PortalWireMessageType, | |||
fromHexString, | |||
hexToBytes, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
bytesToHex
and hexToBytes
should be imported from @ethereumjs/util
@alivia-g we updated |
Closed due to lack of follow up |
fixes #624