findNodes: remove self enr exclusion #451
Closed
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
ultralight fails this portal-hive findNodes test:
node a
is at distanced
tonode b
node a
sendsfindNodes
tonode b
for distanced
expected response:
NODES: [ node_b.enr ]
ultralight's
handleFindNodes
method was implemented to exclude a node's ownenr
from aNODES
response.this, like other design choices, was made with the assumption that nodes would always choose to
ping/pong
an unknown node before sending another kind of request. other portal clients were not built with the same assumptions, which became apparent through various portal-hive test results.this fixes the failing portal-hive interop test