UTP-protocol-stream #450
Merged
UTP-protocol-stream #450
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
uTP streams end by emitting a "Stream" event with the compiled content.
While using only 1 network, this was sufficient.
However, if more than one network is active, the individual subprotocols will each be listening for this
Streamevent, and attempt to process / store any content streamed from uTP.This PR fixes the issue by changing the
Streamevent. instead ofStream, uTP will emit the protocol id as the event name.Each subprotocol will listen only for uTP events with its own protocol id.
Note that to do this, the uTP listener setup was moved from the abstract
BaseProtocolclass to the constructors of the individual subprotocols, and each additional sub protocol will need to include this in its constructor.