Clean up dev dependencies #3710
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
acolytec3
added
type: tests
dependencies
There was a problem hiding this comment.
Changes LGTM, however the examples also seem to have a dependency on ethersproject/abi
Also, the browser tests fail (re-ran it once, gave same error):
Run npm run install-browser-deps
> install-browser-deps
> npm install webdriverio @vitest/browser
npm error Cannot read properties of null (reading 'edgesOut')
npm error A complete log of this run can be found in: /home/runner/.npm/_logs/2024-09-29T21_49_25_024Z-debug-0.log
Error: Process completed with exit code 1.
See: https://github.com/ethereumjs/ethereumjs-monorepo/actions/runs/11088816287/job/30825710880?pr=3710
| @@ -68,7 +67,7 @@ | |||
| "@rollup/rollup-linux-x64-gnu": "*" | |||
| }, | |||
| "peerDependencies": { | |||
| "@vitest/browser": "2.1.0", | |||
| "@vitest/browser": "^2.1.0", | |||
| "webdriverio": "^8.39.0" | |||
There was a problem hiding this comment.
If the install-browser-deps now installs specific versions of these dependencies, should we then also remove the caret here to ensure this specific version is installed?
There was a problem hiding this comment.
I tried this but when I run the npm run install-browser-deps script, it automatically adds the caret back (no idea why). It should be okay though since we're installing specific versions from the script.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removes
vitest-plugin-node-polyfillsfrom our dev dependencies and fixes related testsRemoves
@ethersproject/abisince it was only used to derive calldata for a single test